[PATCH] D149912: [clangd] downgrade missing-includes diagnostic to Information level

Thu May 4 15:23:12 PDT 2023

sammccall added a comment.

This change is just one option to be evaluated for making these diagnostics more user-friendly.

Mostly sending the patch now to attach some screenshots...
Effect in VSCode (blue underline, visible in problems view, filterable)
F27332814: image.png <https://reviews.llvm.org/F27332814>

"Hint" severity in VSCode (ellipsis, not visible in problems view)
F27332825: image.png <https://reviews.llvm.org/F27332825>
(This seems worse: the three-dots rendering does suggest "action here" rather than "issue here", and not being *able* to show these in the problems view seems unfortunate too)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149912/new/

https://reviews.llvm.org/D149912