[PATCH] D134042: [clang-format] Fix alignment in #else preprocessor blocks

Mitchell via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 4 14:29:14 PDT 2023


mitchell-stellar added a comment.

I retract my objection. I forgot that from clang-format's perspective, `#else` blocks in separate functions have the same indent and nesting level, and thus the same "scope", so the alignment issues may persist there. You will see misalignment in `#else` blocks over an entire source file whether you keep or revert this fix (i.e. pick your poison.) I suppose based on precedent we keep the misalignments I wanted to fix since I introduced misalignments in other cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134042/new/

https://reviews.llvm.org/D134042



More information about the cfe-commits mailing list