[PATCH] D133863: [RISCV] Add MC support of RISCV zcmt Extension

Jessica Clarke via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 4 11:51:23 PDT 2023


jrtc27 added inline comments.


================
Comment at: llvm/test/MC/RISCV/rv32zcmt-invalid.s:9
+
+# CHECK-ERROR: error: immediate must be an integer in the range [0, 255]
+cm.jalt 256
----------------
This is wrong; the immediate must be in the range [32, 255]. This needs to be enforced in the assembler and the error needs to reflect that. We also need tests that check these cases (cm.jt with something in [32, 255] and cm.jalt with something in [0, 31]).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133863/new/

https://reviews.llvm.org/D133863



More information about the cfe-commits mailing list