[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

Bruno Cardoso Lopes via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 4 10:55:21 PDT 2023


bruno added a comment.

Thanks Duncan.

> Given that header maps are somewhat Apple-specific

Some non-obvious background: It began Apple specific, but Meta uses them at scale as well, pretty important for us to get this right.

> and unit test coverage is a bit lacking for these sorts of interactions, it'd be nice for someone to check this with Apple-internal stuff.

+1, we got some feedback from Apple folks some time ago, trying to revive this so @ivanmurashko and others can kill more internal technical debt.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103930/new/

https://reviews.llvm.org/D103930



More information about the cfe-commits mailing list