[PATCH] D148663: [RFC][clangd] Use interpolation for CDB pushed via LSP protocol

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added a comment.

I agree with Ilya's concerns here.

We deliberately don't mess with compile flags pushed over LSP. These are "overrides" to whatever information we have from other sources, turning on interpolation at this override layer implies we'll never fallback to other sources of information (as inference will always pick a target, it doesn't have a "that's too bad" threshold).
The contract on the LSP based compile flag setting requires clients to be "capable" of managing files somehow, having some mixed support is unlikely to benefit other users and more likely to break things as we're changing behaviour now (instead of fallback to underlying compilation database, we'll have interpolation).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148663/new/

https://reviews.llvm.org/D148663