[PATCH] D149643: [clang-format] Correctly limit formatted ranges when specifying qualifier alignment

Colin Ogilvie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 4 02:14:26 PDT 2023


cogilvie added a comment.

In D149643#4316128 <https://reviews.llvm.org/D149643#4316128>, @MyDeveloperDay wrote:

> Thanks for the patch...this tells me people are starting to use this feature in anger!! i.e. your formatting via git-clang-format (which is brave!) ;-) which means you have the code modifying features perhaps on my default...
>
> LGTM, if you will need someone to land this for you we'll need your name and email address, if not please wait for @owenpan

Thanks for the reviews.

Yes formatting modifications by default seems to work well when working on older codebases where applying changes to the whole file hides the real intent of a change.

Please submit this for me with the details Colin Ogilvie colin.ogilvie at kdab.com


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149643/new/

https://reviews.llvm.org/D149643



More information about the cfe-commits mailing list