[PATCH] D148689: [clang][Interp] Handle PredefinedExprs

Timm Bäder via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 4 00:34:44 PDT 2023


tbaeder added inline comments.


================
Comment at: clang/test/AST/Interp/literals.cpp:783
+
+namespace PredefinedExprs {
+  constexpr char heh(unsigned index) {
----------------
shafik wrote:
> Can we add tests for each predefined expressions, it does not look like there are a lot of them. 
Not sure that adds much value? Didn't the output of `__PRETTY_FUNCTION__` change at some point in the last release even, which would make this test brittle?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148689/new/

https://reviews.llvm.org/D148689



More information about the cfe-commits mailing list