[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

Job Noorman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 4 00:23:29 PDT 2023


jobnoorman added a comment.

In D148767#4316464 <https://reviews.llvm.org/D148767#4316464>, @chapuni wrote:

> In D148767#4315667 <https://reviews.llvm.org/D148767#4315667>, @jobnoorman wrote:
>
>> Hi, this seems to have broken my bolt+debug+shared build. I don't think there are build bots for this configuration but you can reproduce it like this:
>
> Sorry for inconvenience. Could you add `CodeGenTypes` in `LINK_COMPONENTS` please?

No worries. It feels a bit wrong though to have to add transitive dependencies to `LINK_COMPONENTS`.

My build is also fixed by moving the implementation of `LLT::dump` to a .cpp file. Would it be an option to apply the following patch?

F27324556: llt-link-fix.patch <https://reviews.llvm.org/F27324556>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148767/new/

https://reviews.llvm.org/D148767



More information about the cfe-commits mailing list