[PATCH] D149800: [WIP][PGO] Add ability to mark cold functions as optsize/minsize/optnone

Teresa Johnson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 3 18:46:06 PDT 2023


tejohnson added a subscriber: yamauchi.
tejohnson added a comment.

Previously @yamauchi did a bunch of work related to this called PGSO (Profile Guided Size Optimization). See the functions in https://github.com/llvm-mirror/llvm/blob/master/lib/Transforms/Utils/SizeOpts.cpp, which are used to guide a number of optimizations that can affect code size. Do you know why those weren't sufficient?

@davidxl may remember the details, but iirc fully using minsize/optnone for cold funcs might have been too big of a hammer performance-wise.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149800/new/

https://reviews.llvm.org/D149800



More information about the cfe-commits mailing list