[PATCH] D148924: [clang] Show error if defaulted comparions operator function is volatile or has ref-qualifier &&.
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed May 3 11:49:38 PDT 2023
aaron.ballman added reviewers: hubert.reinterpretcast, shafik, rsmith.
aaron.ballman added a subscriber: rsmith.
aaron.ballman added a comment.
Did you verify that the rest of P2002R1 was implemented correctly? There are a lot more changes in that paper than just this tiny bit, so if we're not certain this finishes things, we shouldn't mark the status as complete (but if we're figuring out what's missing, we should capture those details somewhere so we know what's left to do)
https://github.com/llvm/llvm-project/commit/b74a381296eef048911bb22dc4eb2d3598460470 is what marked the status as partial, but there's no explanation as to why it was partial. Perhaps @rsmith remembers what was left to be done there.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148924/new/
https://reviews.llvm.org/D148924
More information about the cfe-commits
mailing list