[PATCH] D149695: MS inline asm: remove obsolete code adding AOK_SizeDirective (e.g. dword ptr)

Wed May 3 10:27:08 PDT 2023

MaskRay added a comment.

In D149695#4315194 <https://reviews.llvm.org/D149695#4315194>, @hans wrote:

>> The AOK_SizeDirective part from 5b37c181291210bedfbb7a6af5d51229f3652ef0
>> (2014-08) seems unneeded nowadays (the root cause has likely been fixed
>> elsewhere).
>
> Would it be possible to confirm when/if the size directive here became unnecessary?

I compared the assembled output from C test files. They are identical. (I know it would be best to prove this by fully understanding the logic, but that appears difficult...)

> The generated object files for CodeGen/ms-inline-asm-functions.c, CodeGen/ms-inline-asm-functions.c, and CodeGenCXX/ms-inline-asm-fields.cpp are unchanged with just this patch.
>
> When D149579 <https://reviews.llvm.org/D149579> is subsequently applied, the FIXME part of kptr in CodeGen/ms-inline-asm-functions.c will be fixed.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149695/new/

https://reviews.llvm.org/D149695