[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

Arthur Eubanks via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 2 15:31:44 PDT 2023


aeubanks added a comment.

added the warning, not sure if this needs more tests for testing the interaction between `-pedantic`, `-Wmicrosoft`, `-Wmicrosoft-init-from-predefined` or if that's already assumed to work



================
Comment at: clang/test/Modules/predefined.cpp:6
+// RUN: %clang_cc1 -x c++ -std=c++20 -emit-module-interface a.h -o a.pcm -fms-extensions
+// RUN: %clang_cc1 -std=c++20 a.cpp -fmodule-file=A=a.pcm -fms-extensions -fsyntax-only
+
----------------
aaron.ballman wrote:
> Er, should we have a `-verify` on this as well as `// expected-no-diagnostics`?
isn't that tested by the Sema test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146764/new/

https://reviews.llvm.org/D146764



More information about the cfe-commits mailing list