[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by value

Tue May 2 12:22:53 PDT 2023

erichkeane added a comment.

In D149647#4313311 <https://reviews.llvm.org/D149647#4313311>, @HazardyKnusperkeks wrote:

> But it is plain wrong.
> It was done on purpose, so that e.g. `RemoveBracesLLVM` is not set when the `SemiRemover` does its work.

Ah, shoot, you're right!  I missed that the 'return' was in a lambda!  Thanks for the good catch!  I think this patch is just 'wrong' in its entirety, and this is a case where Coverity needs to be suppressed.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149647/new/

https://reviews.llvm.org/D149647