[PATCH] D149104: [Demangle] make llvm::demangle take std::string_view rather than const std::string&

[Nick Desaulniers via Phabricator via cfe-commits]

nickdesaulniers marked an inline comment as done.
nickdesaulniers added a comment.

Thanks for the review!



================
Comment at: llvm/docs/ReleaseNotes.rst:289
 
+* ``llvm::demangle`` now takes a ``std::string_view`` rather than a
+  ``const std::string&``. Be careful passing temporaries into
----------------
MaskRay wrote:
> The text wrapping appears to use a very small `set textwidth` (neovim)?
No, just me manually correcting it; otherwise we have a line ending like `<backtick><backtic>const`
which looks odd to me.  I don't think it matters for rendering restructured text either way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149104/new/

https://reviews.llvm.org/D149104