[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

Dave Green via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 2 10:25:49 PDT 2023


dmgreen added subscribers: nikic, spatel, efriedma.
dmgreen added a comment.

Hello. It sounds like it is really close to being OK. The combine of the shift just seem to make things more difficult.

The `icmp ult i1 %cmp4.i, true` is just a not, would it help if it was actually an xor? Or if the `not(icmp sgt)` was changed to a slt earlier?

I was taking a look at the example but I am not super sure what to suggest. Would it be best if the code that detect min/max looked through not's?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143624/new/

https://reviews.llvm.org/D143624



More information about the cfe-commits mailing list