[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

Tue May 2 09:31:27 PDT 2023

eddyz87 planned changes to this revision.
eddyz87 added a comment.

In D143967#4312746 <https://reviews.llvm.org/D143967#4312746>, @yonghong-song wrote:

> I see the following in the Summary:
>
>   Type tag for CVR modifier type
>   
>   C:
>   
>   volatile int __attribute__((btf_type_tag("__b"))) b;
>   
>   DWARF:
>   
>   0x31:   DW_TAG_variable
>             DW_AT_name      ("b")
>             DW_AT_type      (0x3c "volatile int")
>   
>   0x3c:   DW_TAG_volatile_type
>             DW_AT_type      (0x45 "int")
>   
>   0x41:     DW_TAG_LLVM_annotation
>               DW_AT_name    ("btf:type_tag")
>               DW_AT_const_value     ("__b")
>
> Basically, the btf_type_tag is put under 'volatile' type in dwarf. Is this what gcc also agrees with?

We decided against it but changes to force all type tags after CVR modifiers are not implemented, should probably add a wip tag.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143967/new/

https://reviews.llvm.org/D143967