[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

Sergei Barannikov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 2 08:59:13 PDT 2023


barannikov88 added a comment.

In D148767#4311589 <https://reviews.llvm.org/D148767#4311589>, @chapuni wrote:

> In D148767#4311564 <https://reviews.llvm.org/D148767#4311564>, @barannikov88 wrote:
>
>> Adding CodeGen dependency to MCTargetDesc/AsmParser/Disassembler does not seem right. Why is it necessary?
>
> This commit shows they may depend on `CodeGen` theoretically and actually (but not efficient)
> I will decouple again in D148769 <https://reviews.llvm.org/D148769>.

Sorry, I don't follow. They may theoretically depend on anything. Why CodeGen/CodeGenTypes, specifically?
If they don't require it, why add it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148767/new/

https://reviews.llvm.org/D148767



More information about the cfe-commits mailing list