[PATCH] D149272: [clang] Call printName to get name of Decl
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue May 2 08:56:40 PDT 2023
This revision was automatically updated to reflect the committed changes.
Closed by commit rGea6ecdbfe09d: Call printName to get name of Decl (authored by dankm, committed by aaron.ballman).
Changed prior to commit:
https://reviews.llvm.org/D149272?vs=518050&id=518761#toc
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149272/new/
https://reviews.llvm.org/D149272
Files:
clang/docs/ReleaseNotes.rst
clang/lib/AST/Decl.cpp
clang/lib/AST/DeclarationName.cpp
clang/test/CodeGen/debug-prefix-map.cpp
Index: clang/test/CodeGen/debug-prefix-map.cpp
===================================================================
--- /dev/null
+++ clang/test/CodeGen/debug-prefix-map.cpp
@@ -0,0 +1,11 @@
+// RUN: %clang_cc1 -debug-info-kind=standalone -fdebug-prefix-map=%p=./UNLIKELY_PATH/empty -S %s -emit-llvm -o - | FileCheck %s
+
+struct alignas(64) an {
+ struct {
+ unsigned char x{0};
+ } arr[64];
+};
+
+struct an *pan = new an;
+
+// CHECK: !DISubprogram(name: "(unnamed struct at ./UNLIKELY_PATH/empty{{/|\\\\}}{{.*}}",
Index: clang/lib/AST/DeclarationName.cpp
===================================================================
--- clang/lib/AST/DeclarationName.cpp
+++ clang/lib/AST/DeclarationName.cpp
@@ -117,12 +117,12 @@
Policy.adjustForCPlusPlus();
if (const RecordType *ClassRec = ClassType->getAs<RecordType>()) {
- OS << *ClassRec->getDecl();
+ ClassRec->getDecl()->printName(OS, Policy);
return;
}
if (Policy.SuppressTemplateArgsInCXXConstructors) {
if (auto *InjTy = ClassType->getAs<InjectedClassNameType>()) {
- OS << *InjTy->getDecl();
+ InjTy->getDecl()->printName(OS, Policy);
return;
}
}
Index: clang/lib/AST/Decl.cpp
===================================================================
--- clang/lib/AST/Decl.cpp
+++ clang/lib/AST/Decl.cpp
@@ -1635,8 +1635,8 @@
llvm_unreachable("unknown module kind");
}
-void NamedDecl::printName(raw_ostream &OS, const PrintingPolicy&) const {
- OS << Name;
+void NamedDecl::printName(raw_ostream &OS, const PrintingPolicy &Policy) const {
+ Name.print(OS, Policy);
}
void NamedDecl::printName(raw_ostream &OS) const {
Index: clang/docs/ReleaseNotes.rst
===================================================================
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -340,6 +340,8 @@
- Fix the assertion hit when generating code for global variable initializer of
_BitInt(1) type.
(`#62207 <https://github.com/llvm/llvm-project/issues/62207>`_)
+- Fix lambdas and other anonymous function names not respecting ``-fdebug-prefix-map``
+ (`#62192 <https://github.com/llvm/llvm-project/issues/62192>`_)
Bug Fixes to Compiler Builtins
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149272.518761.patch
Type: text/x-patch
Size: 2218 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230502/7d89f098/attachment.bin>
More information about the cfe-commits
mailing list