[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

Tue May 2 08:05:19 PDT 2023

erichkeane added a comment.

In D146178#4312473 <https://reviews.llvm.org/D146178#4312473>, @davidtgoldblatt wrote:

> This breaks ~the world in the versions of libstdc++ I can easily check -- see e.g. https://gcc.godbolt.org/z/ETeGzc3ve (crashes at this commit, changes to an error at ce861ec782ae3f41807b61e855512aaccf3c2149 <https://reviews.llvm.org/rGce861ec782ae3f41807b61e855512aaccf3c2149>).
>
> I'm not deep enough into this nook of the language to tell if the bug is here or libstdc++, though.

Anything that is fixed by e861ec782 is almost definitely a clang bug. I objected to that quite strongly in this patch, and am quite disappointed that it made it back in.  We're likely going to have a significant number of clang bugs that were previously an assert now be an odd, incorrect diagnostic.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146178/new/

https://reviews.llvm.org/D146178