[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

Tue May 2 07:17:46 PDT 2023

simonwallis2 added inline comments.

================
Comment at: llvm/lib/Target/ARM/ARMSubtarget.cpp:434
   // range otherwise.
-  return !NoMovt && hasV8MBaselineOps() &&
+  return !NoMovt && hasV6MOps() &&
          (isTargetWindows() || !OptMinSize || genExecuteOnly());
----------------
simonwallis2 wrote:
> V6M does not have Movt.
> At face value, this line looks wrong and leads to about 30 unit test fails.
> 
I clarify: there are no test fails with this patch on its own.
The unit test fails I saw where when building this patch in conjunction with related patch https://reviews.llvm.org/D149443

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149444/new/

https://reviews.llvm.org/D149444