[PATCH] D149182: Remove -Wpacked false positive for non-pod types where the layout isn't directly changed

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 2 06:41:33 PDT 2023


aaron.ballman added a comment.

Precommit CI found a valid issue (at least on Debian, the Windows failure appears to be unrelated but it's really hard to tell from that output). Also, this should have a release note, right?



================
Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:2203-2205
     // Warn if we packed it unnecessarily, when the unpacked alignment is not
     // greater than the one after packing, the size in bits doesn't change and
     // the offset of each field is identical.
----------------
You probably should update the comment to explain the new changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149182/new/

https://reviews.llvm.org/D149182



More information about the cfe-commits mailing list