[PATCH] D148944: [clang][Driver] Fix crash with unsupported architectures in MinGW and CrossWindows.

Tue May 2 01:13:34 PDT 2023

mstorsjo added inline comments.

================
Comment at: clang/test/Driver/unsupported-target-arch.c:33
+// RUN: FileCheck --input-file=%t.err --check-prefix=CHECK-NOARCH-CROSSWINDOWS %s
+// CHECK-NOARCH-CROSSWINDOWS: error: unknown target triple 'noarch-unknown-windows-itanium', please use -triple or -arch
----------------
MaskRay wrote:
> mstorsjo wrote:
> > Separate side note; the suggested option `-triple` isn't really a clang driver level option, and `-arch` is only relevant for darwin targets (AFAIK) - so maybe the error message text should be revised?
> The part ", please use -triple or -arch" is almost always wrong.
> 
> For cc1, the error is due to a specified but unknown -triple, we should not suggest specifying -triple.
> For driver, -triple and -arch are not driver options.
> 
> I just removed the hint from the diagnostic.
`-arch` is a driver option, for darwin targets though. But I agree that it's probably best to leave it out since it's more misleading than helping here (and `-triple` is indeed not a relevant option here).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148944/new/

https://reviews.llvm.org/D148944