[PATCH] D148767: Restore CodeGen/LowLevelType

NAKAMURA Takumi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 1 22:57:06 PDT 2023


chapuni added a comment.

In D148767#4311529 <https://reviews.llvm.org/D148767#4311529>, @MaskRay wrote:

> Add some information why this is restored? Assume that people may not read the depended patches (`Depends on D145937, D146352, and D148768.`).

Yes sure. This was just an isolated diff with similar changes at first.

In D148767#4311564 <https://reviews.llvm.org/D148767#4311564>, @barannikov88 wrote:

> Adding CodeGen dependency to MCTargetDesc/AsmParser/Disassembler does not seem right. Why is it necessary?

This commit shows they may depend on `CodeGen` theoretically and actually (but not efficient)
I will decouple again in D148769 <https://reviews.llvm.org/D148769>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148767/new/

https://reviews.llvm.org/D148767



More information about the cfe-commits mailing list