[PATCH] D149495: [RISCV] Add sifive-x280 processor and support V extension in SiFive7

Craig Topper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 1 21:54:26 PDT 2023


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVProcessors.td:169
 
+def SIFIVE_X280 : RISCVProcessorModel<"sifive-x280", SiFive7Model,
+                                      [Feature64Bit,
----------------
I would prefer that we add sifive-x280 in a single patch with all of its features. Currently zba/zbb are in a different patch. I don't think there's any restriction about adding a feature to a CPU without it being present in the scheduler model.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149495/new/

https://reviews.llvm.org/D149495



More information about the cfe-commits mailing list