[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added a comment.

I have read prior discussions and https://discourse.llvm.org/t/rfc-improving-clangs-middle-and-back-end-diagnostics/69261 .

The current approach seems reasonable.

The summary should incorporate more information. `inlined.from` isn't mentioned at all.



================
Comment at: clang/lib/CodeGen/CodeGenAction.cpp:864
+  for (auto Dec : llvm::enumerate(InliningDecisions))
+    Diags.Report(Dec.index() ? diag::note_fe_backend_inlined
+                             : diag::note_fe_backend_in)
----------------
Shall we use `Diags.Report(LocCookie, ...`?


================
Comment at: llvm/test/Transforms/Inline/dontcall-attributes.ll:2
+; RUN: opt -S -o - -passes=inline %s \
+; RUN:  | FileCheck %s --check-prefixes=CHECK-BOTH,CHECK
+; RUN: opt -S -o - -passes=always-inline %s \
----------------
2-space indentation.

Actually I think the line is short enough, so no indentation is needed. You can use `< ` to remove `-o -`


================
Comment at: llvm/test/Transforms/Inline/dontcall-attributes.ll:80
+; CHECK-NEXT: !2 = !{!"bar", !"baz"}
+; CHECK-NEXT: !3 = !{!"a"}
+; CHECK-NEXT: !4 = !{!"always_callee"}
----------------
It's useful to have a Itanium mangled name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141451/new/

https://reviews.llvm.org/D141451