[PATCH] D148944: [clang][Driver] Fix crash with unsupported architectures in MinGW and CrossWindows.

Mon May 1 18:27:11 PDT 2023

MaskRay accepted this revision.
MaskRay added a comment.

Looks great!

================
Comment at: clang/test/Driver/unsupported-target-arch.c:33
+// RUN: FileCheck --input-file=%t.err --check-prefix=CHECK-NOARCH-CROSSWINDOWS %s
+// CHECK-NOARCH-CROSSWINDOWS: error: unknown target triple 'noarch-unknown-windows-itanium', please use -triple or -arch
----------------
mstorsjo wrote:
> Separate side note; the suggested option `-triple` isn't really a clang driver level option, and `-arch` is only relevant for darwin targets (AFAIK) - so maybe the error message text should be revised?
The part ", please use -triple or -arch" is almost always wrong.

For cc1, the error is due to a specified but unknown -triple, we should not suggest specifying -triple.
For driver, -triple and -arch are not driver options.

I just removed the hint from the diagnostic.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148944/new/

https://reviews.llvm.org/D148944