[PATCH] D148769: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 1 16:51:12 PDT 2023


dblaikie accepted this revision.
dblaikie added a comment.

I wouldn't mind a follow-up commit that creates a new/separate directory (llvm/{lib,include/llvm}/CodeGenTypes) but that's probably a lot of unnecessary churn too, so I can appreciate the argument against it - if folks reckon it's better this way, that's OK too. It can just get a bit confusing when the directory/naming doesn't match the layering, etc. Might make it more likely someone regresses these boundaries by introducing new dependencies that break the layering here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148769/new/

https://reviews.llvm.org/D148769



More information about the cfe-commits mailing list