[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

[Matt Arsenault via Phabricator via cfe-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM. It may not be the end step and may be annoying to make further changes from this point, but on its own this isn't worse than before



================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:998
 
     // TODO: Should images get their own address space?
+    Info.fallbackAddressSpace = AMDGPUAS::BUFFER_RESOURCE;
----------------
Should this todo be dropped?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145441/new/

https://reviews.llvm.org/D145441