[PATCH] D145343: [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE`

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Apr 30 21:24:33 PDT 2023


yaxunl added a comment.

In D145343#4172643 <https://reviews.llvm.org/D145343#4172643>, @tra wrote:

> Can `__has_feature` be used to accomplish what you need?

There are a few issues using `__has_feature` or similar builtin macros to check target feature, which has been discussed in https://reviews.llvm.org/D125555 . One of the concerns is the stability of target feature name.

Using a predefined macro does not have such concern.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145343/new/

https://reviews.llvm.org/D145343



More information about the cfe-commits mailing list