[PATCH] D149553: [clang] Use -std=c++23 instead of -std=c++2b

Mark de Wever via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Apr 30 11:32:06 PDT 2023


Mordante added inline comments.


================
Comment at: libcxx/test/tools/clang_tidy_checks/uglify_attributes.cpp:46
 
-  if (lang_opts.CPlusPlus2b) {
     attributes.emplace_back("assume");
----------------
philnik wrote:
> You probably want to `#ifdef` this based on Clang 16/17.
Yeah I noticed that when I uploaded the diff and the CI started the libc++ CI instead of Clang.

For now I'll undo this hunk and will do that in a different patch. That way I can test with the Clang CI.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149553/new/

https://reviews.llvm.org/D149553



More information about the cfe-commits mailing list