[PATCH] D149551: [Interpreter] Filter out RISC-V +relax feature

Vassil Vassilev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Apr 30 11:01:55 PDT 2023


v.g.vassilev added a comment.

This looks reasonable to me. Is there a way we could check when `+relax` start working to remember to re-add this feature?



================
Comment at: clang/lib/Interpreter/IncrementalExecutor.cpp:46
   auto JTMB = JITTargetMachineBuilder(TI.getTriple());
-  JTMB.addFeatures(TI.getTargetOpts().Features);
+  for (const auto &F : TI.getTargetOpts().Features) {
+    if (F == "+relax")
----------------
Can you add a comment here why we skip this feature?

This change does not seem riscv-specific. Is that intentional?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149551/new/

https://reviews.llvm.org/D149551



More information about the cfe-commits mailing list