[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Apr 29 16:28:42 PDT 2023


shafik added a comment.

Thank you for the fix.

I have some questions, why don't we always call `CheckDeductionGuideDeclarator` when calling `CXXDeductionGuideDecl::Create`, I felt like perhaps `CheckDeductionGuideDeclarator` should be rolled into `CXXDeductionGuideDecl::Create` but then I noticed they are not paired up in other locations.

CC @rsmith


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149516/new/

https://reviews.llvm.org/D149516



More information about the cfe-commits mailing list