[PATCH] D146490: [Support] On Windows, ensure that UniqueID is really stable

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Apr 29 14:29:54 PDT 2023


mstorsjo added a comment.

In D146490#4307269 <https://reviews.llvm.org/D146490#4307269>, @falhumai96 wrote:

> I would like to follow up on this issue whether or not there has been an update on it.

There's no update currently; I think there's some amount of consensus that this approach, while fixing the issue, would cause too much other collateral issues.

I'm considering making a patch that switches to hashing the canonicalized path, for the cases where we know the path isn't a local path; it's not an entirely correct solution, but a rough approximation for when the file IDs are stable or not. I just haven't had time to try doing that yet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146490/new/

https://reviews.llvm.org/D146490



More information about the cfe-commits mailing list