[PATCH] D147888: Update declaration message of extern linkage

Krishna Narayanan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Apr 29 11:49:40 PDT 2023


Krishna-13-cyber added a comment.

In D147888#4288149 <https://reviews.llvm.org/D147888#4288149>, @Krishna-13-cyber wrote:

> I have tried a little modification from my side thinking on a beneficial note. I will make the changes to all the other test files as well if this diagnostic representation goes well after mentor review.
>
> For refactoring and restructuring the whole of the re-declaration would need some time I have been through it and would initiate another patch for that,In the concern of giving or having just one diagnostic for getting all cases of re-declaration would also need multiple conditional or switch statements inside our function block.At present we have the same with conditional statements taking care of each linkage but it has multiple permutations of diagnostic messages which is nice but can be improved.GCC differs only for this case of extern linkage which can be better/precise in clang where as others seem to be more precise in clang than former as I worked out with good number of test cases regarding this.

Ping!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147888/new/

https://reviews.llvm.org/D147888



More information about the cfe-commits mailing list