[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

Sat Apr 29 11:04:45 PDT 2023

barannikov88 added a comment.

Thank you all for taking a look!

In D148094#4296346 <https://reviews.llvm.org/D148094#4296346>, @aaron.ballman wrote:

> I did not verify that the refactoring didn't change functionality, but spot-checking did not find any differences.

In D148094#4302879 <https://reviews.llvm.org/D148094#4302879>, @efriedma wrote:

> I'm assuming there isn't actually any changed code, just moving code around.

Apart from code moving this patch splits some methods into
declaration + definition so that the header files only need to include "TargetInfo.h".

This could be avoided by taking a different approach, i.e. the header files
contain only a factory function and cpp files contain the implementation
(of both ABIInfo and TargetCodeGenInfo). This is not a very C++-ish way,
but it would make the changes more straingforward.
I can do it if it's preferable.

In D148094#4296351 <https://reviews.llvm.org/D148094#4296351>, @MaskRay wrote:

> This refactoring looks reasonable to me as well. In `clang/lib/Driver`, we have D30372 <https://reviews.llvm.org/D30372> that splits some huge files into target-specific files.

Thanks, I've updated the RFC with this link.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148094/new/

https://reviews.llvm.org/D148094