[PATCH] D149361: [profiling] Improve error message for raw profile header mismatches

Fri Apr 28 05:19:36 PDT 2023

Dinistro added inline comments.

================
Comment at: llvm/unittests/ProfileData/InstrProfTest.cpp:1359
   auto RawProfileReaderOrErr = InstrProfReader::create(std::move(RawProfile));
   ASSERT_TRUE(InstrProfError::take(RawProfileReaderOrErr.takeError()) ==
               instrprof_error::unrecognized_format);
----------------
Dinistro wrote:
> It seems that this and the following similar line do not compile. I assume that the necessary flags to activate this test were not provided in the CI executed for this revision. 
> 
> Crashing build: https://lab.llvm.org/buildbot/#/builders/104/builds/11668/steps/6/logs/stdio
I creatred and landed a revision that fixes this https://reviews.llvm.org/D149434

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149361/new/

https://reviews.llvm.org/D149361