[PATCH] D134821: [flang][driver] Allow main program to be in an archive

[Shao-Ce SUN via Phabricator via cfe-commits]

sunshaoce added a comment.

In D134821#4304690 <https://reviews.llvm.org/D134821#4304690>, @awarzynski wrote:

> I've just reverted this patch - for context please see https://reviews.llvm.org/D149429.
>
> @sunshaoce This was committed <https://reviews.llvm.org/rG876df74dd47196a9ca3b4fff21ffb5441491a0a0> without acknowledging @ekieri 's contribution, so didn't follow the official guidelines: Attribution of Changes <https://llvm.org/docs/DeveloperPolicy.html#attribution-of-changes>. IMHO, we should keep Emil as the author of this change (he has done the lion share of this highly non-trivial work) and add you as a co-author <https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-github>. Unless @ekieri has some other preference :) (I am happy as long as we follow the guidelines).
>
> Either way, thank you **both** for contributing! Now, lets try to figure out what caused the issue with the bots.

Sorry for not following the official attribution guidelines. I agree with your suggestion to keep @ekieri as the main author. Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134821/new/

https://reviews.llvm.org/D134821