[PATCH] D148944: [clang][Driver] Fix crash with unsupported architectures in MinGW and CrossWindows.

[Martin Storsjö via Phabricator via cfe-commits]

mstorsjo added a comment.

I think the code changes make sense; these are trivial to hit by a user, so they shouldn't be `llvm_unreachable`.



================
Comment at: clang/test/Driver/unsupported-target-arch.c:33
+// RUN: FileCheck --input-file=%t.err --check-prefix=CHECK-NOARCH-CROSSWINDOWS %s
+// CHECK-NOARCH-CROSSWINDOWS: error: unknown target triple 'noarch-unknown-windows-itanium', please use -triple or -arch
----------------
Separate side note; the suggested option `-triple` isn't really a clang driver level option, and `-arch` is only relevant for darwin targets (AFAIK) - so maybe the error message text should be revised?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148944/new/

https://reviews.llvm.org/D148944