[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

[Eli Friedman via Phabricator via cfe-commits]

efriedma added inline comments.


================
Comment at: clang/lib/AST/MicrosoftMangle.cpp:1250
+      for (unsigned I = 1, IE = ID->getChainingSize(); I < IE; ++I)
+        mangleSourceName("<unnamed-tag>");
+
----------------
Weird indentation


================
Comment at: clang/lib/AST/MicrosoftMangle.cpp:1816
 
-      QualType T = Base.getType();
+      std::stack<char> EntryTypeStack;
+      SmallVector<std::function<void()>, 2> EntryManglers;
----------------
Please just use SmallVector instead of std::stack.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146386/new/

https://reviews.llvm.org/D146386