[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

Kamau Bridgeman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 27 12:41:11 PDT 2023


kamaub accepted this revision.
kamaub added a comment.
This revision is now accepted and ready to land.

Hello, sorry for missing you ping and delaying the patch so long just for test case adjustments, thank you for addressing them.
Everything LGTM but lei and I had one request that can be made before you commit:

Please split the two functions and associated run line from ppc-p10-feature-builtins.c into two files named as follows
ppc-p10-mma-builtin-err.c
ppc-p10-paired-vec-memops-builtin-err.c


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143467/new/

https://reviews.llvm.org/D143467



More information about the cfe-commits mailing list