[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 27 11:29:33 PDT 2023


aaron.ballman added a comment.

In D148439#4299178 <https://reviews.llvm.org/D148439#4299178>, @kbobyrev wrote:

> Thanks Aaron!
>
> Yes, fair enough, that looks good to me, probably no need to move a sanity check to the front of `main()` in this case.
>
> Also, just as a note: I don't know how many people use `clang-rename` anymore (especially with `clangd` being present), I rewrote a lot of what clang-rename has to offer for `clangd` with better precision and results. I think the tool is still useful, but not as much as before.

Should we consider deprecating clang-rename in favor of clangd, or do you think that's premature?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148439/new/

https://reviews.llvm.org/D148439



More information about the cfe-commits mailing list