[PATCH] D148505: Allow `__attribute__((warn_unused))` on individual constructors

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 27 10:53:13 PDT 2023


aaron.ballman added a comment.

In D148505#4300483 <https://reviews.llvm.org/D148505#4300483>, @sberg wrote:

>> But the fact that these two attributes already confuse users (AND we've got unused as an attribute in the mix as well, which doesn't help) means we should proceed with caution (and likely coordinate with GCC given that all three of these attributes came from their implementation).
>
> I've brought this up at https://gcc.gnu.org/pipermail/gcc/2023-April/241205.html "GCC/Clang attributes guiding warnings about unused entities" now.  (I tried to cross-post that also to the Clang Frontend discourse category, but that probably didn't work.)

Thank you for poking on this! FWIW, I don't know that there's a way to cross-post to Discourse (but if I'm wrong and there is, I'd love to know how!).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148505/new/

https://reviews.llvm.org/D148505



More information about the cfe-commits mailing list