[PATCH] D147875: [clang][Diagnostics] Show line numbers when printing code snippets

Piotr Zegar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 27 00:09:09 PDT 2023


PiotrZSL added inline comments.


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/cert/uppercase-literal-suffix-integer.cpp:34
   // CHECK-MESSAGES-NEXT: ^~
-  // CHECK-MESSAGES-NEXT: {{^ *}}L{{$}}
+  // CHECK-MESSAGES-NEXT: {{^ *| *}}L{{$}}
   // CHECK-FIXES: static constexpr auto v5 = 1L;
----------------
In theory you should escape this character (`|`) by using `\`, otherwise it could be interpreted as an regexp or. Still looks like this test file passes, so 7 to go.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147875/new/

https://reviews.llvm.org/D147875



More information about the cfe-commits mailing list