[PATCH] D148757: [clang] Apply -fcoverage-prefix-map reverse order

Gulfem Savrun Yeniceri via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 26 17:07:43 PDT 2023


gulfem added inline comments.


================
Comment at: clang/include/clang/Basic/CodeGenOptions.h:211
+
+  /// Prefix replacement map for coverage.
+  llvm::SmallVector<std::pair<std::string, std::string>, 0> CoveragePrefixMap;
----------------
MaskRay wrote:
> MaskRay wrote:
> > While adding a comment, clarify what coverage it is? There are multiple coverage instrumentation features in Clang.
> The declaration should not repeat the comment at the use site.
> 
> I am asking for what coverage features this CoveragePrefixMap is used for...
@MaskRay does this sound good to you?
```
/// Prefix replacement map for source-based code coverage to remap source
/// file paths in coverage mapping.
llvm::SmallVector<std::pair<std::string, std::string>, 0> CoveragePrefixMap;
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148757/new/

https://reviews.llvm.org/D148757



More information about the cfe-commits mailing list