[PATCH] D146873: [2/11][POC][Clang][RISCV] Define RVV tuple types

[Craig Topper via Phabricator via cfe-commits]

craig.topper added inline comments.


================
Comment at: clang/lib/CodeGen/CGCall.cpp:3063
+          llvm::Type *DstTy = Ptr.getElementType();
+          llvm::TypeSize SrcSize = CGM.getDataLayout().getTypeAllocSize(STy);
+          llvm::TypeSize DstSize = CGM.getDataLayout().getTypeAllocSize(DstTy);
----------------
The Dstty, SrcSize and DstSize variables are unused in released builds.


================
Comment at: clang/lib/CodeGen/CGCall.cpp:3070
+
+          llvm::Value *LoadedStructValue = CreateCoercedLoad(Ptr, STy, *this);
+
----------------
What are we loading here?

Is there a test for this code?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146873/new/

https://reviews.llvm.org/D146873