[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando Cazalet-Hyams via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 26 09:58:22 PDT 2023


Orlando added a comment.

In D146987#4299081 <https://reviews.llvm.org/D146987#4299081>, @paulkirth wrote:

> @jmorse Sorry it took me a bit to set up, but I ran an experiment in our CI that reverted the change that disabled this as default and tried it for x86. It looks like this patch is working OK for us now: https://ci.chromium.org/raw/build/logs.chromium.org/fuchsia/led/paulkirth_google.com/df38ff794f44284ff34f63e5dc1f1d41b25225b1241c14eff15a9f0a4b189afb/+/build.proto?server=chromium-swarm.appspot.com
>
> I'm reasonably confident that should mean you won't run into issues. The caveat here is that I can't easily launch experiments across all combinations of platforms and hardware, so it's possible there may still be an issue. I think that's unlikely given how this has been manifesting, so I'd say you're good to try again in our perspective.

Thank you for doing that, that's really helpful. Just to double check - that is a non-LTO but otherwise optimised build of fuchsia?

Once D149137 <https://reviews.llvm.org/D149137> has been accepted I'll be able to try this again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146987/new/

https://reviews.llvm.org/D146987



More information about the cfe-commits mailing list