[PATCH] D148088: [RFC][clangd] Move preamble index task to a seperate task

[Kugan Vivekanandarajah via Phabricator via cfe-commits]

kuganv created this revision.
Herald added subscribers: kadircet, arphaman, javed.absar.
Herald added a project: All.
kuganv updated this revision to Diff 517147.
kuganv added a comment.
kuganv edited the summary of this revision.
kuganv added reviewers: kadircet, sam, ilya-biryukov, nridge.
kuganv added subscribers: DmitryPolukhin, ivanmurashko.
kuganv published this revision for review.
Herald added subscribers: cfe-commits, MaskRay.
Herald added a project: clang-tools-extra.

Removed wrong assert


We would like to move the preamble index out of the critical path. 
This patch is an RFC to get feedback on the correct implementation and potential pitfalls to keep into consideration.

I am not entirely sure if the lazy AST initialisation would create using Preamble AST in parallel. I tried with tsan enabled clangd but it seems to work OK (at least for the cases I tried)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D148088

Files:
  clang-tools-extra/clangd/ClangdServer.cpp
  clang-tools-extra/clangd/TUScheduler.cpp
  clang-tools-extra/clangd/TUScheduler.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D148088.517147.patch
Type: text/x-patch
Size: 4516 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230426/38fd8559/attachment.bin>