[PATCH] D148663: [RFC][clangd] Use interpolation for CDB pushed via LSP protocol

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 26 04:11:08 PDT 2023


ilya-biryukov added a comment.

I wanted to chime in and provide a bit of context.
This was a long time ago, so I might misremember, so take this with a grain of salt.

Idea behind pushing the CDB over LSP was to allow the capable client to **fully** control the commands produced for the files.
Decisions like interpolation were pushed towards the clients intentionally, not accidentally.
IIRC, the motivation back in the day was either sourcekit-lsp or Theia.

I will let other do the actual review, just wanted to bring up the history for a complete picutre.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148663/new/

https://reviews.llvm.org/D148663



More information about the cfe-commits mailing list