[PATCH] D149017: [RISCV] Rewrite all found class-based subroutines to functions

[Wang Pengcheng via Phabricator via cfe-commits]

pcwang-thead added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:703
 class VPseudoUSLoadMask<VReg RetClass, int EEW> :
-      Pseudo<(outs GetVRegNoV0<RetClass>.R:$rd),
-              (ins GetVRegNoV0<RetClass>.R:$merge,
+      Pseudo<(outs GetVRegNoV0'(RetClass):$rd),
+              (ins GetVRegNoV0'(RetClass):$merge,
----------------
michaelmaitland wrote:
> Typo with the `'`? This also happens multiple times below.
> 
> 
No, it is by design. A single quote is added before `(` to solve the grammar ambiguity between DAG and function call. The design may be changed however.
Please see https://discourse.llvm.org/t/tablegen-introduce-function-and-lambda/70160#h-13-function-call-5 also. :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149017/new/

https://reviews.llvm.org/D149017