[PATCH] D149098: [Clang] Add tests and mark as implemented WG14 N2728 (char16_t & char32_t string literals shall be UTF-16 & UTF-32)

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.

LGTM!



================
Comment at: clang/test/Lexer/char-literal.cpp:49
+#ifndef __cplusplus
+// expected-error at -2 {{universal character name refers to a control character}}
+#endif
----------------
cor3ntin wrote:
> I think these tests would be clearer with a different verify tag rather than an ifdef, but it's kinda preexisting so feel free to ignore.
That'd be a nice cleanup for post-commit though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149098/new/

https://reviews.llvm.org/D149098